Add AES256-GCM-SHA384 to the allowed SSL ciphers #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
force-pushed
the
ryan/ZD-12187
branch
from
434aa92 to
1f99ca0
Compare
|
LGTM but I'm not a maintainer. @chef/chef-server-maintainers ? |
|
I think this is reasonable, but please add a comment explaining the deviation for mozilla's "modern" advice. cc @lamont-granquist @markan @rhass |
|
👍 Looks reasonable, but yes, please comment for reason for adding this (so we know when/if to sunset it) |
AWS's Clasic ELB health check tool requires this cipher in order to proxy to Chef Server nodes. Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
force-pushed
the
ryan/ZD-12187
branch
from
1f99ca0 to
1357880
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS's Clasic ELB health check tool requires this cipher in order to
proxy to Chef Server nodes.